[circt-test] fix lit config for circt-bmc #7884
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unlsycn
force-pushed
the
test-bmc-fix
branch
from
fcf9bae
to
32e722d
Compare
This was referenced Nov 24, 2024
unlsycn
force-pushed
the
test-bmc-fix
branch
from
32e722d
to
7a07ffb
Compare
Signed-off-by: unlsycn <[email protected]>
|
One confusing point is that the Github CI can pass this test without path substitution and the additional PATH variable, which seems to be an existing CIRCT binary path in the PATH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7857 introduces a Python script to test
circt-bmc, but there are two problems:lit.cfg.pyso that lit can correctly substitute the path in the test.circt-optbut the executable is not in the PATH variable causing python cannot find it. This PR simply addscirct_tool_dirto PATH to resolve it, but I think a better way is to get rid of the python script and allow lit to substitute the path.